• Andrew Jones's avatar
    arm64: KVM: Set cpsr before spsr on fault injection · 89581f06
    Andrew Jones authored
    We need to set cpsr before determining the spsr bank, as the bank
    depends on the target exception level of the injection, not the
    current mode of the vcpu. Normally this is one in the same (EL1),
    but not when we manage to trap an EL0 fault. It still doesn't really
    matter for the 64-bit EL0 case though, as vcpu_spsr() unconditionally
    uses the EL1 bank for that. However the 32-bit EL0 case gets fun, as
    that path will lead to the BUG() in vcpu_spsr32().
    
    This patch fixes the assignment order and also modifies some white
    space in order to better group pairs of lines that have strict order.
    
    Cc: stable@vger.kernel.org # v4.5
    Signed-off-by: default avatarAndrew Jones <drjones@redhat.com>
    Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
    89581f06
inject_fault.c 6.15 KB