• Daniel Kurtz's avatar
    spi: change post transfer udelay() to usleep_range() for long delays · 8244bd3a
    Daniel Kurtz authored
    The spi_transfer parameter delay_usecs allows specifying a time to wait
    after transferring a spi message.  This wait can be quite long - some
    devices, such as some Chrome OS ECs, require as much as 2000 usecs after
    a SPI transaction, before it can respond.
    
    (cf: arch/arm64/boot/dts/nvidia/tegra132-norrin.dts:
       google,cros-ec-spi-msg-delay = <2000>
    )
    
    Blocking a CPU for 2 msecs in a busy loop like this doesn't seem very
    friendly to other processes, so change the blocking delay to a sleep
    to allow other things to use this CPU (or so it can sleep).
    
    This should be safe to do, because:
     (a) A post-transaction delay like this is always specified as a minimum
         wait time
     (b) A delay here is most likely not very time sensitive, as it occurs
         after all data has been transferred
     (c) This delay occurs in a non-critical section of the spi worker thread
         so where it is safe to sleep.
    
    Two caveats:
     1) To avoid penalizing short delays, still use udelay for delays < 10us.
     2) usleep_range() very often picks the upper bound, an upper bounds 10%
        should be plenty.
    Signed-off-by: default avatarDaniel Kurtz <djkurtz@chromium.org>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    8244bd3a
spi.c 87.7 KB