• Miklos Szeredi's avatar
    mm: dont clear PG_uptodate on truncate/invalidate · 84209e02
    Miklos Szeredi authored
    Brian Wang reported that a FUSE filesystem exported through NFS could
    return I/O errors on read.  This was traced to splice_direct_to_actor()
    returning a short or zero count when racing with page invalidation.
    
    However this is not FUSE or NFSD specific, other filesystems (notably
    NFS) also call invalidate_inode_pages2() to purge stale data from the
    cache.
    
    If this happens while such pages are sitting in a pipe buffer, then
    splice(2) from the pipe can return zero, and read(2) from the pipe can
    return ENODATA.
    
    The zero return is especially bad, since it implies end-of-file or
    disconnected pipe/socket, and is documented as such for splice.  But
    returning an error for read() is also nasty, when in fact there was no
    error (data becoming stale is not an error).
    
    The same problems can be triggered by "hole punching" with
    madvise(MADV_REMOVE).
    
    Fix this by not clearing the PG_uptodate flag on truncation and
    invalidation.
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@suse.cz>
    Acked-by: default avatarNick Piggin <nickpiggin@yahoo.com.au>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Jens Axboe <jens.axboe@oracle.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    84209e02
truncate.c 12.9 KB