• Sourabh Jain's avatar
    powerpc/crash: add crash memory hotplug support · 849599b7
    Sourabh Jain authored
    Extend the arch crash hotplug handler, as introduced by the patch title
    ("powerpc: add crash CPU hotplug support"), to also support memory
    add/remove events.
    
    Elfcorehdr describes the memory of the crash kernel to capture the
    kernel; hence, it needs to be updated if memory resources change due to
    memory add/remove events. Therefore, arch_crash_handle_hotplug_event()
    is updated to recreate the elfcorehdr and replace it with the previous
    one on memory add/remove events.
    
    The memblock list is used to prepare the elfcorehdr. In the case of
    memory hot remove, the memblock list is updated after the arch crash
    hotplug handler is triggered, as depicted in Figure 1. Thus, the
    hot-removed memory is explicitly removed from the crash memory ranges
    to ensure that the memory ranges added to elfcorehdr do not include the
    hot-removed memory.
    
        Memory remove
              |
              v
        Offline pages
              |
              v
     Initiate memory notify call <----> crash hotplug handler
     chain for MEM_OFFLINE event
              |
              v
     Update memblock list
    
     	Figure 1
    
    There are two system calls, `kexec_file_load` and `kexec_load`, used to
    load the kdump image. A few changes have been made to ensure that the
    kernel can safely update the elfcorehdr component of the kdump image for
    both system calls.
    
    For the kexec_file_load syscall, kdump image is prepared in the kernel.
    To support an increasing number of memory regions, the elfcorehdr is
    built with extra buffer space to ensure that it can accommodate
    additional memory ranges in future.
    
    For the kexec_load syscall, the elfcorehdr is updated only if the
    KEXEC_CRASH_HOTPLUG_SUPPORT kexec flag is passed to the kernel by the
    kexec tool. Passing this flag to the kernel indicates that the
    elfcorehdr is built to accommodate additional memory ranges and the
    elfcorehdr segment is not considered for SHA calculation, making it safe
    to update.
    
    The changes related to this feature are kept under the CRASH_HOTPLUG
    config, and it is enabled by default.
    Signed-off-by: default avatarSourabh Jain <sourabhjain@linux.ibm.com>
    Acked-by: default avatarHari Bathini <hbathini@linux.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://msgid.link/20240326055413.186534-7-sourabhjain@linux.ibm.com
    849599b7
crash.c 14.3 KB