• Darrick J. Wong's avatar
    xfs: disable reaping in fscounters scrub · 2d5f38a3
    Darrick J. Wong authored
    The fscounters scrub code doesn't work properly because it cannot
    quiesce updates to the percpu counters in the filesystem, hence it
    returns false corruption reports.  This has been fixed properly in
    one of the online repair patchsets that are under review by replacing
    the xchk_disable_reaping calls with an exclusive filesystem freeze.
    Disabling background gc isn't sufficient to fix the problem.
    
    In other words, scrub doesn't need to call xfs_inodegc_stop, which is
    just as well since it wasn't correct to allow scrub to call
    xfs_inodegc_start when something else could be calling xfs_inodegc_stop
    (e.g. trying to freeze the filesystem).
    
    Neuter the scrubber for now, and remove the xchk_*_reaping functions.
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    2d5f38a3
scrub.h 5.9 KB