• Grygorii Strashko's avatar
    irqchip/crossbar: Restore set_wake functionality · 8200fe43
    Grygorii Strashko authored
    The TI crossbar irqchip doesn't provides any facility to configure the
    wakeup sources, but the conversion to hierarchical irqdomains set the
    irq_set_wake callback to irq_chip_set_wake_parent. The parent chip
    (OMAP wakeupgen) has no irq_set_wake function either so the call will
    fail with -ENOSYS. As a result the irq_set_wake() call in the resume
    path will trigger an 'Unbalanced wake disable' warning.
    
    Before the conversion the GIC irqchip was the top level irqchip and
    correctly flagged with IRQCHIP_SKIP_SET_WAKE.
    
    Restore the correct behaviour by removing the irq_set_type callback
    from the crossbar irqchip and set the IRQCHIP_SKIP_SET_WAKE flag which
    lets the irq_set_irq_wake() call from the driver succeed.
    
    [ tglx: Massaged changelog ]
    
    Fixes: 783d3186 ('irqchip: crossbar: Convert dra7 crossbar...')
    Signed-off-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
    Cc: Sudeep Holla <sudeep.holla@arm.com>
    Cc: <linux@arm.linux.org.uk>
    Cc: <nsekhar@ti.com>
    Cc: <jason@lakedaemon.net>
    Cc: <balbi@ti.com>
    Cc: <linux-arm-kernel@lists.infradead.org>
    Cc: <tony@atomide.com>
    Cc: <marc.zyngier@arm.com>
    Cc: stable@vger.kernel.org # 4.1
    Link: http://lkml.kernel.org/r/1439554830-19502-7-git-send-email-grygorii.strashko@ti.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    8200fe43
irq-crossbar.c 8.36 KB