• Dexuan Cui's avatar
    PCI: hv: Avoid a kmemleak false positive caused by the hbus buffer · 877b911a
    Dexuan Cui authored
    With the recent 59bb4798 ("mm, sl[aou]b: guarantee natural
    alignment for kmalloc(power-of-two)"), kzalloc() is able to allocate
    a 4KB buffer that is guaranteed to be 4KB-aligned. Here the size and
    alignment of hbus is important because hbus's field
    retarget_msi_interrupt_params must not cross a 4KB page boundary.
    
    Here we prefer kzalloc to get_zeroed_page(), because a buffer
    allocated by the latter is not tracked and scanned by kmemleak, and
    hence kmemleak reports the pointer contained in the hbus buffer
    (i.e. the hpdev struct, which is created in new_pcichild_device() and
    is tracked by hbus->children) as memory leak (false positive).
    
    If the kernel doesn't have 59bb4798, get_zeroed_page() *must* be
    used to allocate the hbus buffer and we can avoid the kmemleak false
    positive by using kmemleak_alloc() and kmemleak_free() to ask
    kmemleak to track and scan the hbus buffer.
    Reported-by: default avatarLili Deng <v-lide@microsoft.com>
    Signed-off-by: default avatarDexuan Cui <decui@microsoft.com>
    Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: default avatarMichael Kelley <mikelley@microsoft.com>
    877b911a
pci-hyperv.c 90 KB