• Linus Walleij's avatar
    ARM: 8894/1: boot: Replace open-coded nop with macro · 6583d829
    Linus Walleij authored
    This open-coded nop as mov r0, r0 is a development history
    artifact.
    
    First commit b11fe388
    ("ARM: 6663/1: make Thumb2 kernel entry point more similar
    to the ARM one") moved the code around so that the nops
    would come before the conditional thumb instructions, as it
    turned out that some boot loaders were patching the initial
    nop instructions in the kernel. At this point it is clear
    that all mov r0,r0 are open-coded nops.
    
    Then commit 81a0bc39 ("ARM: add UEFI stub support")
    moved things around and defined __nop for EFI support and
    missed this open-coded nop.
    
    commit 06a4b6d0
    ("ARM: 8677/1: boot/compressed: fix decompressor header
    layout for v7-M") makes all invocations of __nop be wide,
    but that is fine, because this is what we want: the
    mov r0,r0 is inside ifndef CONFIG_THUMB2_KERNEL.
    
    Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Acked-by: default avatarNicolas Pitre <nico@fluxnic.net>
    Acked-by: default avatarRoy Franz <rfranz@marvell.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
    6583d829
head.S 37.5 KB