• Filipe Manana's avatar
    btrfs: send: cache utimes operations for directories if possible · 3e49363b
    Filipe Manana authored
    Whenever we add or remove an entry to a directory, we issue an utimes
    command for the directory. If we add 1000 entries to a directory (create
    1000 files under it or move 1000 files to it), then we issue the same
    utimes command 1000 times, which increases the send stream size, results
    in more pipe IO, one search in the send b+tree, allocating one path for
    the search, etc, as well as making the receiver do a system call for each
    duplicated utimes command.
    
    We also issue an utimes command when we create a new directory, but later
    we might add entries to it corresponding to inodes with an higher inode
    number, so it's pointless to issue the utimes command before we create
    the last inode under the directory.
    
    So use a lru cache to track directories for which we must send a utimes
    command. When we need to remove an entry from the cache, we issue the
    utimes command for the respective directory. When finishing the send
    operation, we go over each cache element and issue the respective utimes
    command. Finally the caching is entirely optional, just a performance
    optimization, meaning that if we fail to cache (due to memory allocation
    failure), we issue the utimes command right away, that is, we fallback
    to the previous, unoptimized, behaviour.
    
    This patch belongs to a patchset comprised of the following patches:
    
      btrfs: send: directly return from did_overwrite_ref() and simplify it
      btrfs: send: avoid unnecessary generation search at did_overwrite_ref()
      btrfs: send: directly return from will_overwrite_ref() and simplify it
      btrfs: send: avoid extra b+tree searches when checking reference overrides
      btrfs: send: remove send_progress argument from can_rmdir()
      btrfs: send: avoid duplicated orphan dir allocation and initialization
      btrfs: send: avoid unnecessary orphan dir rbtree search at can_rmdir()
      btrfs: send: reduce searches on parent root when checking if dir can be removed
      btrfs: send: iterate waiting dir move rbtree only once when processing refs
      btrfs: send: initialize all the red black trees earlier
      btrfs: send: genericize the backref cache to allow it to be reused
      btrfs: adapt lru cache to allow for 64 bits keys on 32 bits systems
      btrfs: send: cache information about created directories
      btrfs: allow a generation number to be associated with lru cache entries
      btrfs: add an api to delete a specific entry from the lru cache
      btrfs: send: use the lru cache to implement the name cache
      btrfs: send: update size of roots array for backref cache entries
      btrfs: send: cache utimes operations for directories if possible
    
    The following test was run before and after applying the whole patchset,
    and on a non-debug kernel (Debian's default kernel config):
    
       #!/bin/bash
    
       MNT=/mnt/sdi
       DEV=/dev/sdi
    
       mkfs.btrfs -f $DEV > /dev/null
       mount $DEV $MNT
    
       mkdir $MNT/A
       for ((i = 1; i <= 20000; i++)); do
           echo -n > $MNT/A/file_$i
       done
    
       btrfs subvolume snapshot -r $MNT $MNT/snap1
    
       mkdir $MNT/B
       for ((i = 20000; i <= 40000; i++)); do
           echo -n > $MNT/B/file_$i
       done
    
       mv $MNT/A/file_* $MNT/B/
    
       btrfs subvolume snapshot -r $MNT $MNT/snap2
    
       start=$(date +%s%N)
       btrfs send -p $MNT/snap1 $MNT/snap2 > /dev/null
       end=$(date +%s%N)
    
       dur=$(( (end - start) / 1000000 ))
       echo "Incremental send took $dur milliseconds"
    
       umount $MNT
    
    Before the whole patchset: 18408 milliseconds
    After the whole patchset:   1942 milliseconds  (9.5x speedup)
    
    Using 60000 files instead of 40000:
    
    Before the whole patchset: 39764 milliseconds
    After the whole patchset:   3076 milliseconds  (12.9x speedup)
    
    Using 20000 files instead of 40000:
    
    Before the whole patchset:  5072 milliseconds
    After the whole patchset:    916 milliseconds  (5.5x speedup)
    Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    3e49363b
lru_cache.c 3.78 KB