• KOSAKI Motohiro's avatar
    ftrace: tracing header should put '#' at the beginning of a line · 888b55dc
    KOSAKI Motohiro authored
    In a recent discussion, Andrew Morton pointed out that tracing header
    should put '#' at the beginning of a line.
    
    Then, we can easily filtered the header by following grep usage:
    
      cat trace | grep -v '^#'
    
    Wakeup trace also has the same header problem.
    
    Comparison of headers displayed:
    
    before this patch:
    
     # tracer: wakeup
     #
     wakeup latency trace v1.1.5 on 2.6.29-rc7-tip-tip
     --------------------------------------------------------------------
      latency: 19059 us, #21277/21277, CPU#1 | (M:desktop VP:0, KP:0, SP:0 HP:0 #P:4)
         -----------------
         | task: kondemand/1-1644 (uid:0 nice:-5 policy:0 rt_prio:0)
         -----------------
    
     #                  _------=> CPU#
     #                 / _-----=> irqs-off
     #                | / _----=> need-resched
     #                || / _---=> hardirq/softirq
     #                ||| / _--=> preempt-depth
     #                |||| /
     #                |||||     delay
     #  cmd     pid   ||||| time  |   caller
     #     \   /      |||||   \   |   /
     irqbalan-1887    1d.s.    0us :   1887:120:R   + [001]  1644:115:S kondemand/1
     irqbalan-1887    1d.s.    1us : default_wake_function <-autoremove_wake_function
     irqbalan-1887    1d.s.    2us : check_preempt_wakeup <-try_to_wake_up
    
    after this patch:
    
     # tracer: wakeup
     #
     # wakeup latency trace v1.1.5 on 2.6.29-rc7-tip-tip
     # --------------------------------------------------------------------
     # latency: 529 us, #530/530, CPU#0 | (M:desktop VP:0, KP:0, SP:0 HP:0 #P:4)
     #    -----------------
     #    | task: kondemand/0-1641 (uid:0 nice:-5 policy:0 rt_prio:0)
     #    -----------------
     #
     #                  _------=> CPU#
     #                 / _-----=> irqs-off
     #                | / _----=> need-resched
     #                || / _---=> hardirq/softirq
     #                ||| / _--=> preempt-depth
     #                |||| /
     #                |||||     delay
     #  cmd     pid   ||||| time  |   caller
     #     \   /      |||||   \   |   /
         sshd-2496    0d.s.    0us :   2496:120:R   + [000]  1641:115:S kondemand/0
         sshd-2496    0d.s.    1us : default_wake_function <-autoremove_wake_function
         sshd-2496    0d.s.    1us : check_preempt_wakeup <-try_to_wake_up
    Signed-off-by: default avatarKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    LKML-Reference: <20090308124421.23C3.A69D9226@jp.fujitsu.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    888b55dc
trace.c 88.7 KB