• Paul Burton's avatar
    MIPS: VDSO: Fix build for binutils < 2.25 · 8919975b
    Paul Burton authored
    Versions of binutils prior to 2.25 are unable to link our VDSO due to an
    unsupported R_MIPS_PC32 relocation generated by the ".word _start - ."
    line of the inline asm in get_vdso_base(). As such, the intent is that
    when building with binutils older than 2.25 we don't build code for
    gettimeofday() & friends in the VDSO that rely upon get_vdso_base().
    
    Commit 24640f23 ("mips: Add support for generic vDSO") converted us
    to using generic VDSO infrastructure, and as part of that the
    gettimeofday() functionality moved to a new vgettimeofday.c file. The
    check for binutils < 2.25 wasn't updated to handle this new filename,
    and so it continues trying to remove the old unused filename from the
    build. The end result is that we try to include the gettimeofday() code
    in builds that will fail to link.
    
    Fix this by updating the binutils < 2.25 case to remove vgettimeofday.c
    from obj-vdso-y, rather than gettimeofday.c.
    Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
    Fixes: 24640f23 ("mips: Add support for generic vDSO")
    Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
    Cc: linux-mips@vger.kernel.org
    8919975b
Makefile 6.3 KB