• NeilBrown's avatar
    md/raid1: don't abort a resync on the first badblock. · 898ece8e
    NeilBrown authored
    commit b7219ccb upstream.
    
    If a resync of a RAID1 array with 2 devices finds a known bad block
    one device it will neither read from, or write to, that device for
    this block offset.
    So there will be one read_target (The other device) and zero write
    targets.
    This condition causes md/raid1 to abort the resync assuming that it
    has finished - without known bad blocks this would be true.
    
    When there are no write targets because of the presence of bad blocks
    we should only skip over the area covered by the bad block.
    RAID10 already gets this right, raid1 doesn't.  Or didn't.
    
    As this can cause a 'sync' to abort early and appear to have succeeded
    it could lead to some data corruption, so it suitable for -stable.
    Reported-by: default avatarAlexander Lyakas <alex.bolshoy@gmail.com>
    Signed-off-by: default avatarNeilBrown <neilb@suse.de>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    898ece8e
raid1.c 74.8 KB