• Edward Adam Davis's avatar
    bluetooth/l2cap: sync sock recv cb and release · 89e856e1
    Edward Adam Davis authored
    The problem occurs between the system call to close the sock and hci_rx_work,
    where the former releases the sock and the latter accesses it without lock protection.
    
               CPU0                       CPU1
               ----                       ----
               sock_close                 hci_rx_work
    	   l2cap_sock_release         hci_acldata_packet
    	   l2cap_sock_kill            l2cap_recv_frame
    	   sk_free                    l2cap_conless_channel
    	                              l2cap_sock_recv_cb
    
    If hci_rx_work processes the data that needs to be received before the sock is
    closed, then everything is normal; Otherwise, the work thread may access the
    released sock when receiving data.
    
    Add a chan mutex in the rx callback of the sock to achieve synchronization between
    the sock release and recv cb.
    
    Sock is dead, so set chan data to NULL, avoid others use invalid sock pointer.
    
    Reported-and-tested-by: syzbot+b7f6f8c9303466e16c8a@syzkaller.appspotmail.com
    Signed-off-by: default avatarEdward Adam Davis <eadavis@qq.com>
    Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
    89e856e1
l2cap_sock.c 43.3 KB