• Andy Gospodarek's avatar
    bonding: properly stop queuing work when requested · a0db2dad
    Andy Gospodarek authored
    During a test where a pair of bonding interfaces using ARP monitoring
    were both brought up and torn down (with an rmmod) repeatedly, a panic
    in the timer code was noticed.  I tracked this down and determined that
    any of the bonding functions that ran as workqueue handlers and requeued
    more work might not properly exit when the module was removed.
    
    There was a flag protected by the bond lock called kill_timers that is
    set when the interface goes down or the module is removed, but many of
    the functions that monitor link status now unlock the bond lock to take
    rtnl first.  There is a chance that another CPU running the rmmod could
    get the lock and set kill_timers after the first check has passed.
    
    This patch does not allow any function to queue work that will make
    itself run unless kill_timers is not set.  I also noticed while doing
    this work that bond_resend_igmp_join_requests did not have a check for
    kill_timers, so I added the needed call there as well.
    Signed-off-by: default avatarAndy Gospodarek <andy@greyhouse.net>
    Reported-by: default avatarLiang Zheng <lzheng@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a0db2dad
bond_main.c 130 KB