• Arnaldo Carvalho de Melo's avatar
    perf probe: Avoid accessing uninitialized 'map' variable · 8a2efd6d
    Arnaldo Carvalho de Melo authored
    Genuine problem detected with clang, the warnings are spot on:
    
      util/probe-event.c:2079:7: error: variable 'map' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
                      if (addr) {
                          ^~~~
      util/probe-event.c:2094:6: note: uninitialized use occurs here
              if (map && !is_kprobe) {
                  ^~~
      util/probe-event.c:2079:3: note: remove the 'if' if its condition is always true
                      if (addr) {
                      ^~~~~~~~~~
      util/probe-event.c:2075:8: error: variable 'map' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                              if (kernel_get_symbol_address_by_name(tp->symbol,
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      util/probe-event.c:2094:6: note: uninitialized use occurs here
              if (map && !is_kprobe) {
                  ^~~
      util/probe-event.c:2075:4: note: remove the 'if' if its condition is always false
                              if (kernel_get_symbol_address_by_name(tp->symbol,
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      util/probe-event.c:2064:17: note: initialize the variable 'map' to silence this warning
              struct map *map;
                             ^
                              = NULL
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: http://lkml.kernel.org/n/tip-m3501el55i10hctfbmi2qxzr@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    8a2efd6d
probe-event.c 79.1 KB