• Sean Christopherson's avatar
    KVM: selftests: Assert that vasprintf() is successful · 7c329bbd
    Sean Christopherson authored
    Assert that vasprintf() succeeds as the "returned" string is undefined
    on failure.  Checking the result also eliminates the only warning with
    default options in KVM selftests, i.e. is the only thing getting in the
    way of compile with -Werror.
    
      lib/test_util.c: In function ‘strdup_printf’:
      lib/test_util.c:390:9: error: ignoring return value of ‘vasprintf’
      declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
      390 |         vasprintf(&str, fmt, ap);
          |         ^~~~~~~~~~~~~~~~~~~~~~~~
    
    Don't bother capturing the return value, allegedly vasprintf() can only
    fail due to a memory allocation failure.
    
    Fixes: dfaf20af ("KVM: arm64: selftests: Replace str_with_index with strdup_printf")
    Cc: Andrew Jones <ajones@ventanamicro.com>
    Cc: Haibo Xu <haibo1.xu@intel.com>
    Cc: Anup Patel <anup@brainfault.org>
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Reviewed-by: default avatarAndrew Jones <ajones@ventanamicro.com>
    Tested-by: default avatarAndrew Jones <ajones@ventanamicro.com>
    Message-Id: <20230914010636.1391735-1-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    7c329bbd
test_util.c 9.24 KB