• Jerome Brunet's avatar
    ASoC: hdmi-codec: drop mutex locking again · 901af18b
    Jerome Brunet authored
    This reverts commit eb1ecadb.
    
    This fixes the following warning reported by lockdep and a potential
    issue with hibernation
    
    ====================================
    WARNING: pulseaudio/1297 still has locks held!
    5.3.0+ #1826 Not tainted
    ------------------------------------
    1 lock held by pulseaudio/1297:
     #0: ee815308 (&hcp->lock){....}, at: hdmi_codec_startup+0x20/0x130
    
    stack backtrace:
    CPU: 0 PID: 1297 Comm: pulseaudio Not tainted 5.3.0+ #1826
    Hardware name: Marvell Dove (Cubox)
    [<c0017b4c>] (unwind_backtrace) from [<c0014d10>] (show_stack+0x10/0x14)
    [<c0014d10>] (show_stack) from [<c00a2d18>] (futex_wait_queue_me+0x13c/0x19c)
    [<c00a2d18>] (futex_wait_queue_me) from [<c00a3630>] (futex_wait+0x184/0x24c)
    [<c00a3630>] (futex_wait) from [<c00a5e1c>] (do_futex+0x334/0x598)
    [<c00a5e1c>] (do_futex) from [<c00a62e8>] (sys_futex_time32+0x118/0x180)
    [<c00a62e8>] (sys_futex_time32) from [<c0009000>] (ret_fast_syscall+0x0/0x54)
    Exception stack(0xebd31fa8 to 0xebd31ff0)
    1fa0:                   00000000 ffffffff 000c8748 00000189 00000001 00000000
    1fc0: 00000000 ffffffff 00000000 000000f0 00000000 00000000 00000000 00056200
    1fe0: 000000f0 beac03a8 b6d6c835 b6d6f456
    
    Fixes: eb1ecadb ("ASoC: hdmi-codec: re-introduce mutex locking")
    Reported-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
    Link: https://lore.kernel.org/r/20191023161203.28955-2-jbrunet@baylibre.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    901af18b
hdmi-codec.c 24.5 KB