• Bart Van Assche's avatar
    locking/lockdep: Make lockdep_unregister_key() honor 'debug_locks' again · 8b39adbe
    Bart Van Assche authored
    If lockdep_register_key() and lockdep_unregister_key() are called with
    debug_locks == false then the following warning is reported:
    
      WARNING: CPU: 2 PID: 15145 at kernel/locking/lockdep.c:4920 lockdep_unregister_key+0x1ad/0x240
    
    That warning is reported because lockdep_unregister_key() ignores the
    value of 'debug_locks' and because the behavior of lockdep_register_key()
    depends on whether or not 'debug_locks' is set. Fix this inconsistency
    by making lockdep_unregister_key() take 'debug_locks' again into
    account.
    Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Waiman Long <longman@redhat.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: shenghui <shhuiw@foxmail.com>
    Fixes: 90c1cba2 ("locking/lockdep: Zap lock classes even with lock debugging disabled")
    Link: http://lkml.kernel.org/r/20190415170538.23491-1-bvanassche@acm.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    8b39adbe
lockdep.c 127 KB