• Bhumika Goyal's avatar
    [media] media: pci: constify vb2_ops structure · 8b6fe20a
    Bhumika Goyal authored
    Declare vb2_ops structure as const as it is only stored in
    the ops field of a vb2_queue structure. This field is of type
    const, so vb2_ops structures having same properties can be made
    const too.
    Done using Coccinelle:
    
    @r1 disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct vb2_ops i@p={...};
    
    @ok1@
    identifier r1.i;
    position p;
    struct sta2x11_vip vip;
    struct vb2_queue q;
    @@
    (
    vip.vb_vidq.ops=&i@p
    |
    q.ops=&i@p
    )
    
    @bad@
    position p!={r1.p,ok1.p};
    identifier r1.i;
    @@
    i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r1.i;
    @@
    +const
    struct vb2_ops i;
    
    File size before:
       text	   data	    bss	    dec	    hex	filename
       8448	    440	      0	   8888	   22b8	media/pci/sta2x11/sta2x11_vip.o
    
    File size after:
       text	   data	    bss	    dec	    hex	filename
       8552	    352	      0	   8904	   22c8	media/pci/sta2x11/sta2x11_vip.o
    Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    8b6fe20a
sta2x11_vip.c 32.8 KB