• Greg Rose's avatar
    openvswitch: Fix for force/commit action failures · 8b97ac5b
    Greg Rose authored
    When there is an established connection in direction A->B, it is
    possible to receive a packet on port B which then executes
    ct(commit,force) without first performing ct() - ie, a lookup.
    In this case, we would expect that this packet can delete the existing
    entry so that we can commit a connection with direction B->A. However,
    currently we only perform a check in skb_nfct_cached() for whether
    OVS_CS_F_TRACKED is set and OVS_CS_F_INVALID is not set, ie that a
    lookup previously occurred. In the above scenario, a lookup has not
    occurred but we should still be able to statelessly look up the
    existing entry and potentially delete the entry if it is in the
    opposite direction.
    
    This patch extends the check to also hint that if the action has the
    force flag set, then we will lookup the existing entry so that the
    force check at the end of skb_nfct_cached has the ability to delete
    the connection.
    
    Fixes: dd41d330b03 ("openvswitch: Add force commit.")
    CC: Pravin Shelar <pshelar@nicira.com>
    CC: dev@openvswitch.org
    Signed-off-by: default avatarJoe Stringer <joe@ovn.org>
    Signed-off-by: default avatarGreg Rose <gvrose8192@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    8b97ac5b
conntrack.c 43.5 KB