• Filipe Manana's avatar
    btrfs: send: iterate waiting dir move rbtree only once when processing refs · 8c139e1d
    Filipe Manana authored
    When processing the new references for an inode, we unnecessarily iterate
    twice the waiting dir moves rbtree, once with is_waiting_for_move() and
    if we found an entry in the rbtree, we iterate it again with a call to
    get_waiting_dir_move(). This is pointless, we can make this simpler and
    more efficient by calling only get_waiting_dir_move(), so just do that.
    
    This patch is part of a larger patchset and the changelog of the last
    patch in the series contains a sample performance test and results.
    The patches that comprise the patchset are the following:
    
      btrfs: send: directly return from did_overwrite_ref() and simplify it
      btrfs: send: avoid unnecessary generation search at did_overwrite_ref()
      btrfs: send: directly return from will_overwrite_ref() and simplify it
      btrfs: send: avoid extra b+tree searches when checking reference overrides
      btrfs: send: remove send_progress argument from can_rmdir()
      btrfs: send: avoid duplicated orphan dir allocation and initialization
      btrfs: send: avoid unnecessary orphan dir rbtree search at can_rmdir()
      btrfs: send: reduce searches on parent root when checking if dir can be removed
      btrfs: send: iterate waiting dir move rbtree only once when processing refs
      btrfs: send: initialize all the red black trees earlier
      btrfs: send: genericize the backref cache to allow it to be reused
      btrfs: adapt lru cache to allow for 64 bits keys on 32 bits systems
      btrfs: send: cache information about created directories
      btrfs: allow a generation number to be associated with lru cache entries
      btrfs: add an api to delete a specific entry from the lru cache
      btrfs: send: use the lru cache to implement the name cache
      btrfs: send: update size of roots array for backref cache entries
      btrfs: send: cache utimes operations for directories if possible
    Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    8c139e1d
send.c 214 KB