• Stephen Suryaputra's avatar
    netfilter: nf_tables: nft_exthdr: the presence return value should be little-endian · b4283366
    Stephen Suryaputra authored
    On big-endian machine, the returned register data when the exthdr is
    present is not being compared correctly because little-endian is
    assumed. The function nft_cmp_fast_mask(), called by nft_cmp_fast_eval()
    and nft_cmp_fast_init(), calls cpu_to_le32().
    
    The following dump also shows that little endian is assumed:
    
    $ nft --debug=netlink add rule ip recordroute forward ip option rr exists counter
    ip
      [ exthdr load ipv4 1b @ 7 + 0 present => reg 1 ]
      [ cmp eq reg 1 0x01000000 ]
      [ counter pkts 0 bytes 0 ]
    
    Lastly, debug print in nft_cmp_fast_init() and nft_cmp_fast_eval() when
    RR option exists in the packet shows that the comparison fails because
    the assumption:
    
    nft_cmp_fast_init:189 priv->sreg=4 desc.len=8 mask=0xff000000 data.data[0]=0x10003e0
    nft_cmp_fast_eval:57 regs->data[priv->sreg=4]=0x1 mask=0xff000000 priv->data=0x1000000
    
    v2: use nft_reg_store8() instead (Florian Westphal). Also to avoid the
        warnings reported by kernel test robot.
    
    Fixes: dbb5281a ("netfilter: nf_tables: add support for matching IPv4 options")
    Fixes: c078ca3b ("netfilter: nft_exthdr: Add support for existence check")
    Signed-off-by: default avatarStephen Suryaputra <ssuryaextr@gmail.com>
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    b4283366
nft_exthdr.c 12.7 KB