• David Chinner's avatar
    [XFS] Prevent looping in xfs_sync_inodes_ag · 8c38ab03
    David Chinner authored
    If the last block of the AG has inodes in it and the AG is an exactly
    power-of-2 size then the last inode in the AG points to the last block in
    the AG. If we try to find the next inode in the AG by adding one to the
    inode number, we increment the inode number past the size of the AG. The
    result is that the macro XFS_INO_TO_AGINO() will strip the AG portion of
    the inode number and return an inode number of zero.
    
    That is, instead of terminating the lookup loop because we hit the inode
    number went outside the valid range for the AG, the search index returns
    to zero and we start traversing the radix tree from the start again. This
    results in an endless loop in xfs_sync_inodes_ag().
    
    Fix it be detecting if the new search index decreases as a result of
    incrementing the current inode number. That indicate an overflow and hence
    that we have finished processing the AG so we can terminate the loop.
    
    SGI-PV: 988142
    
    SGI-Modid: xfs-linux-melb:xfs-kern:32335a
    Signed-off-by: default avatarDavid Chinner <david@fromorbit.com>
    Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
    Signed-off-by: default avatarChristoph Hellwig <hch@infradead.org>
    8c38ab03
xfs_sync.c 19.1 KB