• Sebastian Andrzej Siewior's avatar
    input: ti_am335x_adc: use only FIFO0 and clean up a little · 8c896308
    Sebastian Andrzej Siewior authored
    The driver programs a threshold of "coordinate_readouts" say 5. The
    REG_FIFO0THR registers says it should it be programmed to "threshold
    minus one". The driver does not expect just 5 coordinates but 5 * 2 + 2.
    Multiplied by two because 5 for X and 5 for Y and plus 2 because we have
    two Z.
    The whole thing kind of works because It reads the 5 coordinates for X
    and Y from FIFO0 and FIFO1 and the last element in each FIFO is ignored
    within the loop and read later.
    Nothing guaranties that FIFO1 is ready by the time it is read. In fact I
    could see that that FIFO1 reaturns for Y channels 8,9, 10, 12, 6 and for
    Y channel 7 for Z. The problem is that channel 7 and channel 12 got
    somehow mixed up.
    The other Problem is that FIFO1 is also used by the IIO part leading to
    wrong results if both (tsc & adc) are used.
    
    The patch tries to clean up the whole thing a little:
    - Remove the +1 and -1 in REG_STEPCONFIG, REG_STEPDELAY and its counter
      part in the for loop. This is just confusing.
    
    - Use only FIFO0 in TSC. The fifo has space for 64 entries so should be
      fine.
    
    - Read the whole FIFO in one function and check the channel.
    
    - in case we dawdle around, make sure we only read a multiple of our
      coordinate set. On the second interrupt we will cleanup the remaining
      enties.
    Acked-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    8c896308
ti_am335x_tsc.c 12.5 KB