• Breno Leitao's avatar
    powerpc/xmon: Fix invocation inside lock region · 8d4a8622
    Breno Leitao authored
    Currently xmon needs to get devtree_lock (through rtas_token()) during its
    invocation (at crash time). If there is a crash while devtree_lock is being
    held, then xmon tries to get the lock but spins forever and never get into
    the interactive debugger, as in the following case:
    
    	int *ptr = NULL;
    	raw_spin_lock_irqsave(&devtree_lock, flags);
    	*ptr = 0xdeadbeef;
    
    This patch avoids calling rtas_token(), thus trying to get the same lock,
    at crash time. This new mechanism proposes getting the token at
    initialization time (xmon_init()) and just consuming it at crash time.
    
    This would allow xmon to be possible invoked independent of devtree_lock
    being held or not.
    Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
    Reviewed-by: default avatarThiago Jung Bauermann <bauerman@linux.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    8d4a8622
xmon.c 86.3 KB