• Hou Wenlong's avatar
    KVM: x86/mmu: Don't rebuild page when the page is synced and no tlb flushing is required · 8d5678a7
    Hou Wenlong authored
    Before Commit c3e5e415 ("KVM: X86: Change kvm_sync_page()
    to return true when remote flush is needed"), the return value
    of kvm_sync_page() indicates whether the page is synced, and
    kvm_mmu_get_page() would rebuild page when the sync fails.
    But now, kvm_sync_page() returns false when the page is
    synced and no tlb flushing is required, which leads to
    rebuild page in kvm_mmu_get_page(). So return the return
    value of mmu->sync_page() directly and check it in
    kvm_mmu_get_page(). If the sync fails, the page will be
    zapped and the invalid_list is not empty, so set flush as
    true is accepted in mmu_sync_children().
    
    Cc: stable@vger.kernel.org
    Fixes: c3e5e415 ("KVM: X86: Change kvm_sync_page() to return true when remote flush is needed")
    Signed-off-by: default avatarHou Wenlong <houwenlong.hwl@antgroup.com>
    Acked-by: default avatarLai Jiangshan <jiangshanlai@gmail.com>
    Message-Id: <0dabeeb789f57b0d793f85d073893063e692032d.1647336064.git.houwenlong.hwl@antgroup.com>
    [mmu_sync_children should not flush if the page is zapped. - Paolo]
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    8d5678a7
mmu.c 173 KB