• Marc-André Lureau's avatar
    fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() · 8d59d5bd
    Marc-André Lureau authored
    Dispatch to the appropriate iowrite() instead of casting restricted
    type to u16.
    
    - if fw_cfg_is_mmio:
      before: iowrite16(cpu_to_be16(key))
      after: iowrite16be(key)
    - if !fw_cfg_is_mmio:
      before: iowrite16(cpu_to_le16(key))
      after: iowrite16(key)
      which is equivalent on little-endian systems, where fw_cfg IO is supported.
    
    Fixes:
    $ make C=1 CF=-D__CHECK_ENDIAN__ drivers/firmware/qemu_fw_cfg.o
    
    drivers/firmware/qemu_fw_cfg.c:55:33: warning: restricted __be16 degrades to integer
    drivers/firmware/qemu_fw_cfg.c:55:52: warning: restricted __le16 degrades to integer
    Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    8d59d5bd
qemu_fw_cfg.c 21 KB