• Sergei Shtylyov's avatar
    [MIPS] Alchemy common code style cleanup · c1dcb14e
    Sergei Shtylyov authored
    Fix many errors and warnings given by checkpatch.pl:
    
    - use of C99 // comments;
    
    - missing space between the type and asterisk in a variable declaration;
    
    - space between the asterisk and function/variable name;
    
    - leading spaces instead of tabs;
    
    - space after opening and before closing parentheses;
    
    - initialization of a 'static' variable to 0;
    
    - missing spaces around assignement/comparison operator;
    
    - brace not on the same line with condition (or 'else') in the 'if'/'switch'
      statement;
    
    - missing space between 'if'/'for'/'while' and opening parenthesis;
    
    - use of assignement in 'if' statement's condition;
    
    - printk() without KERN_* facility level;
    
    - EXPORT_SYMBOL() not following its function immediately;
    
    - unnecessary braces for single-statement block;
    
    - adding new 'typedef' (where including <linux/types.h> will do);
    
    - use of 'extern' in the .c file (where it can be avoided by including header);
    
    - line over 80 characters.
    
    In addition to these changes, also do the following:
    
    - insert missing space after opening brace and/or before closing brace in the
      structure initializers;
    
    - insert spaces between operator and its operands;
    
    - put the function's result type and name/parameters on the same line;
    
    - properly indent multi-line expressions;
    
    - remove commented out code;
    
    - remove useless initializers and code;
    
    - remove needless parentheses;
    
    - fix broken/excess indentation;
    
    - add missing spaces between operator and its operands;
    
    - insert missing and remove excess new lines;
    
    - group 'else' and 'if' together where possible;
    
    - make au1xxx_platform_init() 'static';
    
    - regroup variable declarations in pm_do_freq() for prettier look;
    
    - replace numeric literals with the matching macros;
    
    - fix printk() format specifiers mismatching the argument types;
    
    - make the multi-line comment style consistent with the kernel style elsewhere
      by adding empty first line and/or adding space on their left side;
    
    - make two-line comments that only have one line of text one-line;
    
    - fix typos/errors, capitalize acronyms, etc. in the comments;
    
    - fix/remove obsolete references in the comments;
    
    - reformat some comments;
    
    - add comment about the CPU:counter clock ratio to calc_clock();
    
    - update MontaVista copyright;
    
    - remove Pete Popov's and Steve Longerbeam's old email addresses...
    Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
    Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    c1dcb14e
gpio.c 3.8 KB