• Baoquan He's avatar
    drivers/base/cpu: crash data showing should depends on KEXEC_CORE · 4e9e2e4c
    Baoquan He authored
    After commit 88a6f899 ("crash: memory and CPU hotplug sysfs
    attributes"), on x86_64, if only below kernel configs related to kdump are
    set, compiling error are triggered.
    
    ----
    CONFIG_CRASH_CORE=y
    CONFIG_KEXEC_CORE=y
    CONFIG_CRASH_DUMP=y
    CONFIG_CRASH_HOTPLUG=y
    ------
    
    ------------------------------------------------------
    drivers/base/cpu.c: In function `crash_hotplug_show':
    drivers/base/cpu.c:309:40: error: implicit declaration of function `crash_hotplug_cpu_support'; did you mean `crash_hotplug_show'? [-Werror=implicit-function-declaration]
      309 |         return sysfs_emit(buf, "%d\n", crash_hotplug_cpu_support());
          |                                        ^~~~~~~~~~~~~~~~~~~~~~~~~
          |                                        crash_hotplug_show
    cc1: some warnings being treated as errors
    ------------------------------------------------------
    
    CONFIG_KEXEC is used to enable kexec_load interface, the
    crash_notes/crash_notes_size/crash_hotplug showing depends on
    CONFIG_KEXEC is incorrect. It should depend on KEXEC_CORE instead.
    
    Fix it now.
    
    Link: https://lkml.kernel.org/r/20231128055248.659808-1-bhe@redhat.com
    Fixes: 88a6f899 ("crash: memory and CPU hotplug sysfs attributes")
    Signed-off-by: default avatarBaoquan He <bhe@redhat.com>
    Tested-by: Ignat Korchagin <ignat@cloudflare.com>	[compile-time only]
    Tested-by: default avatarAlexander Gordeev <agordeev@linux.ibm.com>
    Reviewed-by: default avatarEric DeVolder <eric_devolder@yahoo.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    4e9e2e4c
cpu.c 15.7 KB