• Benjamin Beichler's avatar
    um: read multiple msg from virtio slave request fd · 714e7634
    Benjamin Beichler authored
    If VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS is activated, the user mode
    linux virtio irq handler only read one msg from the corresponding socket.
    This creates issues, when the device emulation creates multiple call
    requests (e.g. for multiple virtqueues), as the socket buffer tend to fill
    up and the call requests are delayed.
    
    This creates a deadlock situation, when the device simulation blocks,
    because of sending a msg and the kernel side blocks because of
    synchronously waiting for an acknowledge of kick request.
    
    Actually inband notifications are meant to be used in combination with the
    time travel protocol, but it is not required, therefore this corner case
    needs to be handled.
    
    Anyways, in general it seems to be more natural to consume always all
    messages from a socket, instead of only a single one.
    
    Fixes: 2cd097ba ("um: virtio: Implement VHOST_USER_PROTOCOL_F_SLAVE_REQ")
    Signed-off-by: default avatarBenjamin Beichler <benjamin.beichler@uni-rostock.de>
    Reviewed-by: default avatarJohannes Berg <johannes@sipsolutions.net>
    Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
    714e7634
virtio_uml.c 35.5 KB