• Paulo Zanoni's avatar
    drm/i915/fbc: don't print no_fbc_reason to dmesg · 913a3a6a
    Paulo Zanoni authored
    Our dmesg messages started being misleading after we converted to the
    enable+activate model: we always print "Disabling FBC", even when
    we're just deactivating it. So, for example, when I boot my machine
    and do "dmesg | grep -i fbc", I see:
      [drm:intel_fbc_enable] Enabling FBC on pipe A
      [drm:set_no_fbc_reason] Disabling FBC: framebuffer not tiled or fenced
    but then, if I read the debugfs file, I will see:
      $ sudo cat i915_fbc_status
      FBC enabled
      Compressing: yes
    so we can conclude that dmesg is misleading, since FBC is actually
    enabled. What happened is that we deactivated FBC due to fbcon not
    being tiled, but when we silently reactivated it when the display
    manager started. We don't print activation messages since there may be
    way too many of these operations per second during normal desktop
    usage.
    
    One possible solution would be to change set_no_fbc_reason to
    correctly differentiate between disable and deactivation, but we
    removed support from printing activation/deactivation messages in the
    past because they were too frequent. So instead of doing this, let's
    just not print anything on dmesg, and leave the debugfs file if the
    user needs to investigate something. We already print when we enable
    and disable FBC anyway on a given pipe, so this should already help
    triaging bugs.
    Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1453210558-7875-22-git-send-email-paulo.r.zanoni@intel.com
    913a3a6a
intel_fbc.c 34.8 KB