• David Howells's avatar
    netfs: Fix interaction between write-streaming and cachefiles culling · 92a714d7
    David Howells authored
    An issue can occur between write-streaming (storing dirty data in partial
    non-uptodate pages) and a cachefiles object being culled to make space.
    The problem occurs because the cache object is only marked in use while
    there are files open using it.  Once it has been released, it can be culled
    and the cookie marked disabled.
    
    At this point, a streaming write is permitted to occur (if the cache is
    active, we require pages to be prefetched and cached), but the cache can
    become active again before this gets flushed out - and then two effects can
    occur:
    
     (1) The cache may be asked to write out a region that's less than its DIO
         block size (assumed by cachefiles to be PAGE_SIZE) - and this causes
         one of two debugging statements to be emitted.
    
     (2) netfs_how_to_modify() gets confused because it sees a page that isn't
         allowed to be non-uptodate being uptodate and tries to prefetch it -
         leading to a warning that PG_fscache is set twice.
    
    Fix this by the following means:
    
     (1) Add a netfs_inode flag to disallow write-streaming to an inode and set
         it if we ever do local caching of that inode.  It remains set for the
         lifetime of that inode - even if the cookie becomes disabled.
    
     (2) If the no-write-streaming flag is set, then make netfs_how_to_modify()
         always want to prefetch instead.
    
     (3) If netfs_how_to_modify() decides it wants to prefetch a folio, but
         that folio has write-streamed data in it, then it requires the folio
         be flushed first.
    
     (4) Export a counter of the number of times we wanted to prefetch a
         non-uptodate page, but found it had write-streamed data in it.
    
     (5) Export a counter of the number of times we cancelled a write to the
         cache because it didn't DIO align and remove the debug statements.
    Reported-by: default avatarMarc Dionne <marc.dionne@auristor.com>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    cc: Jeff Layton <jlayton@kernel.org>
    cc: linux-cachefs@redhat.com
    cc: linux-erofs@lists.ozlabs.org
    cc: linux-fsdevel@vger.kernel.org
    cc: linux-mm@kvack.org
    92a714d7
io.c 17.7 KB