• Heiko Stuebner's avatar
    ARM: dts: rockchip: explicitly set vcc_sd0 pin to gpio on rk3188-radxarock · a2df0984
    Heiko Stuebner authored
    It is good practice to make the setting of gpio-pinctrls explicitly in the
    devicetree, and in this case even necessary.
    Rockchip boards start with iomux settings set to gpio for most pins and
    while the linux pinctrl driver also implicitly sets the gpio function if
    a pin is requested as gpio that is not necessarily true for other drivers.
    
    The issue in question stems from uboot, where the sdmmc_pwr pin is set
    to function 1 (sdmmc-power) by the bootrom when reading the 1st-stage
    loader. The regulator controlled by the pin is active-low though, so
    when the dwmmc hw-block sets its enabled bit, it actually disables the
    regulator. By changing the pin back to gpio we fix that behaviour.
    Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
    a2df0984
rk3188-radxarock.dts 6.92 KB