• Michael Ellerman's avatar
    powerpc/vmlinux.lds: Don't discard .comment · be5f95c8
    Michael Ellerman authored
    Although the powerpc linker script mentions .comment in the DISCARD
    section, that has never actually caused it to be discarded, because the
    earlier ELF_DETAILS macro (previously STABS_DEBUG) explicitly includes
    .comment.
    
    However commit 99cb0d91 ("arch: fix broken BuildID for arm64 and
    riscv") introduced an earlier use of DISCARD as part of the RO_DATA
    macro. With binutils < 2.36 that causes the DISCARD directives later in
    the script to be applied earlier, causing .comment to actually be
    discarded.
    
    It's confusing to explicitly include and discard .comment, and even more
    so if the behaviour depends on the toolchain version. So don't discard
    .comment in order to maintain the existing behaviour in all cases.
    
    Fixes: 83a092cf ("powerpc: Link warning for orphan sections")
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20230105132349.384666-3-mpe@ellerman.id.au
    be5f95c8
vmlinux.lds.S 9.14 KB