• zijun_hu's avatar
    mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk() · 93c76b6b
    zijun_hu authored
    pcpu_embed_first_chunk() calculates the range a percpu chunk spans into
    @max_distance and uses it to ensure that a chunk is not too big compared
    to the total vmalloc area. However, during calculation, it used incorrect
    top address by adding a unit size to the highest group's base address.
    
    This can make the calculated max_distance slightly smaller than the actual
    distance although given the scale of values involved the error is very
    unlikely to have an actual impact.
    
    Fix this issue by adding the group's size instead of a unit size.
    
    BTW, The type of variable max_distance is changed from size_t to unsigned
    long too based on below consideration:
     - type unsigned long usually have same width with IP core registers and
       can be applied at here very well
     - make @max_distance type consistent with the operand calculated against
       it such as @ai->groups[i].base_offset and macro VMALLOC_TOTAL
     - type unsigned long is more universal then size_t, size_t is type defined
       to unsigned int or unsigned long among various ARCHs usually
    Signed-off-by: default avatarzijun_hu <zijun_hu@htc.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    93c76b6b
percpu.c 66.1 KB