• Kevin Mitchell's avatar
    igb: skip phy status check where unavailable · 942d2ad5
    Kevin Mitchell authored
    igb_read_phy_reg() will silently return, leaving phy_data untouched, if
    hw->ops.read_reg isn't set. Depending on the uninitialized value of
    phy_data, this led to the phy status check either succeeding immediately
    or looping continuously for 2 seconds before emitting a noisy err-level
    timeout. This message went out to the console even though there was no
    actual problem.
    
    Instead, first check if there is read_reg function pointer. If not,
    proceed without trying to check the phy status register.
    
    Fixes: b72f3f72 ("igb: When GbE link up, wait for Remote receiver status condition")
    Signed-off-by: default avatarKevin Mitchell <kevmitch@arista.com>
    Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
    Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    942d2ad5
igb_main.c 269 KB