• Sean Christopherson's avatar
    KVM: Do not zero initialize 'pfn' in hva_to_pfn() · 943dfea8
    Sean Christopherson authored
    Drop the unnecessary initialization of the local 'pfn' variable in
    hva_to_pfn().  First and foremost, '0' is not an invalid pfn, it's a
    perfectly valid pfn on most architectures.  I.e. if hva_to_pfn() were to
    return an "uninitializd" pfn, it would actually be interpeted as a legal
    pfn by most callers.
    
    Second, hva_to_pfn() can't return an uninitialized pfn as hva_to_pfn()
    explicitly sets pfn to an error value (or returns an error value directly)
    if a helper returns failure, and all helpers set the pfn on success.
    
    The zeroing of 'pfn' was introduced by commit 2fc84311 ("KVM:
    reorganize hva_to_pfn"), probably to avoid "uninitialized variable"
    warnings on statements that return pfn.  However, no compiler seems
    to produce them, making the initialization unnecessary.
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20220429010416.2788472-2-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    943dfea8
kvm_main.c 149 KB