• jiada wang's avatar
    ASoC: soc-pcm: check symmetry after hw_params · 957ce0c6
    jiada wang authored
    hw_params may be fixup by be_hw_params_fixup, calling
    soc_pcm_params_symmetry() before hw_params will have issue
    if there is hw_params changes in be_hw_params_fixup.
    
    For example, with following use case
    1. a dai-link which is able to convert sample rate on BE side
    2. set BE playback and capture sample rate to 44100Hz
    3. play a 48000Hz audio stream with this dai-link
    4. record from this dai-link with 44100Hz sample rate
    
    Got following error message when record starts
    [  495.013527]  be_link_ak4613: ASoC: unmatched rate symmetry: 48000 - 44100
    [  495.021729]  be_link_ak4613: ASoC: hw_params BE failed -22
    [  495.028589]  rsnd_link0: ASoC: hw_params BE failed -22
    
    Because in soc_pcm_hw_params(), FE rate is still having value before
    it is fixup by be_hw_params_fixup(), when soc_pcm_params_symmetry() checks
    symmetry, thus soc_pcm_params_symmetry() complains about the unmatched rate
    between the active stream and the new stream tries to start.
    
    This patch moves soc_pcm_params_symmetry() after hw_params to resolve the
    above issue.
    Signed-off-by: default avatarJiada Wang <jiada_wang@mentor.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    957ce0c6
soc-pcm.c 82.7 KB