• AngeloGioacchino Del Regno's avatar
    drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf · 3b8e19a0
    AngeloGioacchino Del Regno authored
    In commit 41ca9caa
    ("drm/mediatek: hdmi: Add check for CEA modes only") a check
    for CEA modes was added to function mtk_hdmi_bridge_mode_valid()
    in order to address possible issues on MT8167;
    moreover, with commit c91026a9
    ("drm/mediatek: hdmi: Add optional limit on maximal HDMI mode clock")
    another similar check was introduced.
    
    Unfortunately though, at the time of writing, MT8173 does not provide
    any mtk_hdmi_conf structure and this is crashing the kernel with NULL
    pointer upon entering mtk_hdmi_bridge_mode_valid(), which happens as
    soon as a HDMI cable gets plugged in.
    
    To fix this regression, add a NULL pointer check for hdmi->conf in the
    said function, restoring HDMI functionality and avoiding NULL pointer
    kernel panics.
    
    Fixes: 41ca9caa ("drm/mediatek: hdmi: Add check for CEA modes only")
    Fixes: c91026a9 ("drm/mediatek: hdmi: Add optional limit on maximal HDMI mode clock")
    Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
    3b8e19a0
mtk_hdmi.c 46.8 KB