• Linus Torvalds's avatar
    e1000e: Fix incorrect debug warning · 95b866d5
    Linus Torvalds authored
    Doing 'WARN_ON(preempt_count())' was horribly horribly wrong, and would
    cause tons of warnings at bootup if PREEMPT was enabled because the
    initcalls currently run with the kernel lock, which increments the
    preempt count.
    
    At the same time, the warning was also insufficient, since it didn't
    check that interrupts were enabled.
    
    The proper debug function to use for something that can sleep and wants
    a warning if it's called in the wrong context is 'might_sleep()'.
    Reported-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    95b866d5
ich8lan.c 65.8 KB