• Tomi Valkeinen's avatar
    OMAP: DSS2: Fix FIFO threshold and burst size for OMAP4 · 5ed8cf5b
    Tomi Valkeinen authored
    The DMA FIFO threshold registers and burst size registers have changed
    for OMAP4.  The current code only handles OMAP2/3 case, and so the
    values are a bit off for OMAP4.  A summary of the differences between
    OMAP2/3 and OMAP4:
    
    Burst size:
    OMAP2/3: 4 x 32 bits / 8 x 32 bits / 16 x 32 bits
    OMAP4: 2 x 128 bits / 4 x 128 bits / 8 x 128 bits
    
    Threshold size:
    OMAP2/3: in bytes (8 bit units)
    OMAP4: in 128bit units
    
    This patch fixes the issue by creating two new helper functions in
    dss_features: dss_feat_get_buffer_size_unit() and
    dss_feat_get_burst_size_unit(). These return (in bytes) the unit size
    for threshold registers and unit size for burst size register,
    respectively, and are used to calculate correct values.
    
    For the threshold size the usage is straightforward. However, the burst
    size register has different multipliers for OMAP2/3 and OMAP4. This
    patch solves the problem by defining the multipliers for the burst size
    as 2x, 4x and 8x, which fit fine for the OMAP4 burst size definition
    (i.e. burst size unit for OMAP4 is 128bits), but requires a slight twist
    on OMAP2/3 by defining the burst size unit as 64bit.
    
    As the driver in practice always uses the maximum burst size, and no use
    case currently exists where we would want to use a smaller burst size,
    this patch changes the driver to hardcode the burst size when
    initializing DISPC. This makes the threshold configuration code somewhat
    simpler.
    Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
    5ed8cf5b
display.c 13 KB