• Mike Snitzer's avatar
    dm: hold DM table for duration of ioctl rather than use blkdev_get · 971888c4
    Mike Snitzer authored
    Commit 519049af ("dm: use blkdev_get rather than bdgrab when issuing
    pass-through ioctl") inadvertantly introduced a regression relative to
    users of device cgroups that issue ioctls (e.g. libvirt).  Using
    blkdev_get() in DM's passthrough ioctl support implicitly introduced a
    cgroup permissions check that would fail unless care were taken to add
    all devices in the IO stack to the device cgroup.  E.g. rather than just
    adding the top-level DM multipath device to the cgroup all the
    underlying devices would need to be allowed.
    
    Fix this, to no longer require allowing all underlying devices, by
    simply holding the live DM table (which includes the table's original
    blkdev_get() reference on the blockdevice that the ioctl will be issued
    to) for the duration of the ioctl.
    
    Also, bump the DM ioctl version so a user can know that their device
    cgroup allow workaround is no longer needed.
    Reported-by: default avatarMichal Privoznik <mprivozn@redhat.com>
    Suggested-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Fixes: 519049af ("dm: use blkdev_get rather than bdgrab when issuing pass-through ioctl")
    Cc: stable@vger.kernel.org # 4.16
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    971888c4
dm.c 72.5 KB