• Julia Lawall's avatar
    MIPS: pci-rt3883: drop unneeded of_node_get · 972cfd55
    Julia Lawall authored
    for_each_child_of_node performs an of_node_get on each iteration, so no
    of_node_get is needed on breaking out of the loop when the device_node
    structure is saved in another variable.
    
    A simplified semantic match that finds this problem is as follows
    (http://coccinelle.lip6.fr):
    
    // <smpl>
    @@
    expression root;
    local idexpression child;
    @@
    
     for_each_child_of_node(root, child) {
       ...
    *  of_node_get(child)
       ...
       break;
     }
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Cc: kernel-janitors@vger.kernel.org
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
    Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Cc: Andrew Lunn <andrew@lunn.ch>
    Cc: Bjorn Helgaas <bhelgaas@google.com>
    Cc: Jason Cooper <jason@lakedaemon.net>
    Patchwork: https://patchwork.linux-mips.org/patch/11357/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    972cfd55
pci-rt3883.c 14.9 KB