• Shannon Nelson's avatar
    ionic: wait on queue start until after IFF_UP · 976ee3b2
    Shannon Nelson authored
    The netif_running() test looks at __LINK_STATE_START which
    gets set before ndo_open() is called, there is a window of
    time between that and when the queues are actually ready to
    be run.  If ionic_check_link_status() notices that the link is
    up very soon after netif_running() becomes true, it might try
    to run the queues before they are ready, causing all manner of
    potential issues.  Since the netdev->flags IFF_UP isn't set
    until after ndo_open() returns, we can wait for that before
    we allow ionic_check_link_status() to start the queues.
    
    On the way back to close, __LINK_STATE_START is cleared before
    calling ndo_stop(), and IFF_UP is cleared after.  Both of
    these need to be true in order to safely stop the queues
    from ionic_check_link_status().
    
    Fixes: 49d3b493 ("ionic: disable the queues on link down")
    Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    976ee3b2
ionic_lif.c 72.7 KB