• Will Deacon's avatar
    oprofile: don't call arch exit code from init code on failure · 979048e1
    Will Deacon authored
    oprofile_init calls oprofile_arch_init to initialise the architecture-specific
    backend code. If this backend code returns failure, oprofile_arch_exit is
    called immediately, making it difficult to allocate and free resources
    correctly.
    
    This patch removes the oprofile_arch_exit call from oprofile_init,
    meaning that all architectures must ensure that oprofile_arch_init
    cleans up any mess it's made before returning an error. As far as
    I can tell, this only affects the code for ARM.
    
    Cc: Robert Richter <robert.richter@amd.com>
    Cc: Matt Fleming <matt@console-pimps.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    Signed-off-by: default avatarRobert Richter <robert.richter@amd.com>
    979048e1
oprof.c 4.88 KB