• Sergei Antonov's avatar
    drm/nouveau/bios: fix a bit shift error introduced by 457e77b2 · 9a118439
    Sergei Antonov authored
    Commit 457e77b2 added two checks applied to a
    value received from nv_rd32(bios, 0x619f04). But after this new piece of code
    is executed, the addr local variable does not hold the same value it used to
    hold before the commit. Here is what is was assigned in the original code:
    	(u64)(nv_rd32(bios, 0x619f04) & 0xffffff00) << 8
    in the committed code it ends up with this value:
    	(u64)(nv_rd32(bios, 0x619f04) >> 8) << 8
    These expressions are obviously not equivalent.
    
    My Nvidia video card does not show anything on the display when I boot a
    kernel containing this commit.
    
    The patch fixes the code so that the new checks are still done, but the
    side effect of an incorrect addr value is gone.
    
    Cc: Ben Skeggs <bskeggs@redhat.com>
    Cc: Dave Airlie <airlied@redhat.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarSergei Antonov <saproj@gmail.com>
    Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
    9a118439
base.c 13.3 KB