• Will Deacon's avatar
    net: tls: Avoid assigning 'const' pointer to non-const pointer · 9a893949
    Will Deacon authored
    tls_build_proto() uses WRITE_ONCE() to assign a 'const' pointer to a
    'non-const' pointer. Cleanups to the implementation of WRITE_ONCE() mean
    that this will give rise to a compiler warning, just like a plain old
    assignment would do:
    
      | net/tls/tls_main.c: In function ‘tls_build_proto’:
      | ./include/linux/compiler.h:229:30: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
      | net/tls/tls_main.c:640:4: note: in expansion of macro ‘smp_store_release’
      |   640 |    smp_store_release(&saved_tcpv6_prot, prot);
      |       |    ^~~~~~~~~~~~~~~~~
    
    Drop the const qualifier from the local 'prot' variable, as it isn't
    needed.
    
    Cc: Boris Pismenny <borisp@mellanox.com>
    Cc: Aviad Yehezkel <aviadye@mellanox.com>
    Cc: John Fastabend <john.fastabend@gmail.com>
    Cc: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: default avatarWill Deacon <will@kernel.org>
    9a893949
tls_main.c 20.9 KB