• Namhyung Kim's avatar
    perf ui/stdio: Fix invalid percentage value of cumulated hist entries · 56772ad4
    Namhyung Kim authored
    On stdio, there's a problem that it shows invalid values for
    callchains in cumulated hist entries.  It's because it only cares
    about the self period.  But with --children behavior, we always add
    callchain info to the cumulated entries so it should use the value in
    that case.
    
    Before:
    
      # Children      Self  Command      Shared Object            Symbol
      # ........  ........  .......  .................  ................
      #
          61.22%     0.32%  swapper  [kernel.kallsyms]      [k] cpu_idle
                        |
                        --- cpu_idle
                           |
                           |--16530.76%-- start_secondary
                           |
                           |--2758.70%-- rest_init
                           |          start_kernel
                           |          x86_64_start_reservations
                           |          x86_64_start_kernel
                            --6837850969203030.00%-- [...]
    
    After:
    
      # Children      Self  Command      Shared Object            Symbol
      # ........  ........  .......  .................  ................
      #
          61.22%     0.32%  swapper  [kernel.kallsyms]      [k] cpu_idle
                        |
                        --- cpu_idle
                           |
                           |--85.70%-- start_secondary
                           |
                            --14.30%-- rest_init
                                      start_kernel
                                      x86_64_start_reservations
                                      x86_64_start_kernel
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Arun Sharma <asharma@fb.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Link: http://lkml.kernel.org/r/1401335910-16832-24-git-send-email-namhyung@kernel.orgSigned-off-by: default avatarJiri Olsa <jolsa@kernel.org>
    56772ad4
hist.c 11.5 KB