• Jingoo Han's avatar
    leds: leds-ns2: set devm_gpio_request_one() flags param correctly · 9d04cbaa
    Jingoo Han authored
    The devm_gpio_request_one() flags parameter was set to:
    
      GPIOF_DIR_OUT | gpio_get_value(template->cmd)
    
    GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:
    
      GPIOF_DIR_OUT   (0 << 0)
      GPIOF_DIR_IN    (1 << 0)
    
    So, when 'gpio_get_value(template->cmd)' is 1, the gpio pin can
    be set as input, instead of output.
    
    To prevent this problem, GPIOF_OUT_INIT flags should be used when
    using devm_gpio_request_one().
    
    Same goes for 'gpio_get_value(template->slow)' case.
    Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
    Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
    9d04cbaa
leds-ns2.c 9.15 KB