• Or Gerlitz's avatar
    net/sched: Fix actions list corruption when adding offloaded tc flows · 9d452ceb
    Or Gerlitz authored
    Prior to commit b3f55bdd, the networking core doesn't wire an in-place
    actions list the when the low level driver is called to offload the flow,
    but all low level drivers do that (call tcf_exts_to_list()) in their
    offloading "add" logic.
    
    Now, the in-place list is set in the core which goes over the list in a loop,
    but also by the hw driver when their offloading code is invoked indirectly:
    
    	cls_xxx add flow -> tc_setup_cb_call -> tc_exts_setup_cb_egdev_call -> hw driver
    
    which messes up the core list instance upon driver return. Fix that by avoiding
    in-place list on the net core code that deals with adding flows.
    
    Fixes: b3f55bdd ('net: sched: introduce per-egress action device callbacks')
    Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
    Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9d452ceb
cls_api.c 28.4 KB